Skip to content

feat: add a warning after a failed connection for brave users#312

Merged
johann-crabnebula merged 7 commits intomainfrom
feat/brave-warning
Jun 12, 2024
Merged

feat: add a warning after a failed connection for brave users#312
johann-crabnebula merged 7 commits intomainfrom
feat/brave-warning

Conversation

@johann-crabnebula
Copy link
Copy Markdown
Contributor

@johann-crabnebula johann-crabnebula commented Jun 10, 2024

Caution

Waiting for Docs PR to be merged

This PR adds the following to the ConnectionFailedDialog.tsx

  • General info where to find our troubleshooting docs
  • Info about the Brave browser shield being troublesome for Brave users

Still need to:

  • Add a docs page on how to set the exception for localhost in Brave
  • Add an adblocker page to the docs

The general hint will always show.

We detect that the user is currently using the Brave browser and only then we will show the Brave hint:

Screenshot 2024-06-10 at 15 24 29

Closes DT-182

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 10, 2024

Deploy Preview for cn-devtools-app ready!

Name Link
🔨 Latest commit 94b9093
🔍 Latest deploy log https://app.netlify.com/sites/cn-devtools-app/deploys/6669050ff692ec0008cb750b
😎 Deploy Preview https://deploy-preview-312--cn-devtools-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment thread clients/web/src/components/warnings/brave-warning.tsx Outdated
Comment thread clients/web/src/components/warnings/brave-warning.tsx Outdated
@johann-crabnebula johann-crabnebula marked this pull request as ready for review June 10, 2024 07:08
@johann-crabnebula johann-crabnebula merged commit cdd41cd into main Jun 12, 2024
@johann-crabnebula johann-crabnebula deleted the feat/brave-warning branch June 12, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants