feat: add a warning after a failed connection for brave users#312
Merged
johann-crabnebula merged 7 commits intomainfrom Jun 12, 2024
Merged
feat: add a warning after a failed connection for brave users#312johann-crabnebula merged 7 commits intomainfrom
johann-crabnebula merged 7 commits intomainfrom
Conversation
✅ Deploy Preview for cn-devtools-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alex-crabnebula
requested changes
Jun 10, 2024
…any promise, Brave browser is running
eb76c28 to
110fe73
Compare
alex-crabnebula
previously approved these changes
Jun 10, 2024
alex-crabnebula
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Waiting for Docs PR to be merged
This PR adds the following to the
ConnectionFailedDialog.tsxStill need to:
The general hint will always show.
We detect that the user is currently using the
Bravebrowser and only then we will show theBravehint:Closes DT-182