[5.x]: Decimal separator of Number in Table field doesnt get localized in Twig if you use decimal comma

[foxtrotcz]

What happened?

Description

If you create Table with Number column, then the Numbers decimal separator doesnt get localized if you used decimal comma.

Steps to reproduce

1. Have two sites. Primary site in non-English language that uses decimal comma in numbers. Secondary site in English.
2. Create Table field with Number column. This Table field should be Not Translatable.
3. Add this Table to some Entry.
4. In Entry write in some number with decimal comma. For example 500,6
5. Print the number in Twig with number filter, like row.value|number
6. Check both English and non-English site output.

Expected behavior

500,6 for non-English (comma)
500.6 for English (point)

Actual behavior

Both show 500,6 (comma)

Additional info

If you use decimal point in the Table, then the formatting works and output of row.value|number will be correct according to site locale.

So for now I will just write all my Table Numbers with decimal point. But this could be improved in future.

Craft CMS version

5.9.22

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[linear-code]

CMS-2062

[brandonkelly]

Numbers, currencies, dates, and times will each be formatted according to the requested site by default, not the site that the content was loaded from. In fact, the |number filter doesn’t have any way of knowing where the passed-in number came from, so it wouldn’t be possible for us to change that behavior even if we wanted to.

The |money, |date, |time, and |datetime filters each have locale arguments that let you override which locale the value should be formatted for, however it seems we overlooked the |number filter!

I just fixed that for Craft 5.10 (5bf2f51), so going forward, you can do this:

{{ row.value|number(locale=entry.site.language) }}

[foxtrotcz]

I think I explained it badly.
I am talking about formatting not working even according to requested site in frontend.

I think easiest way to test is skipping Craft altogether and just trying it in Twig directly. Lets try formatting number 2.3

If your original input number is using decimal point/dot it works and formats output according to requested site locale:
Source: {{ "2.3"|number }}
Output on English site: 2.3
Output on Czech site: 2,3

If you original number uses decimal comma it doesnt work and doesnt format the number for English locale:
Source: {{ "2,3"|number }}
Output on English site: 2,3 <-- WRONG (should be 2.3)
Output on Czech site: 2,3

This same behavior occurs if you have the number saved in Number Table field.
I checked the DB and the number is simply saved in JSON as-is. So 2,3 gets saved in JSON as "2,3".
Maybe there should be some normalization during saving and it should be saved into JSON as English formatter number 2.3? Or the output should handle it? Not sure.

[brandonkelly]

If you original number uses decimal comma it doesnt work and doesnt format the number for English locale:
Source: {{ "2,3"|number }}

Ah, I see the problem.

Number cells in Table fields don’t currently support non-EN-formatted values such as 2,3. So when you save that, the value is getting stored verbatim as "2,3", rather than normalized into the float 2.3.

So row.value|number equates to "2.3"|number, which isn’t a valid input value for the filter, so the filter just returns whatever was passed in.

I just fixed this for Craft 5.10. Going forward, Number cells will be output using the correct formatting, and normalized based on the format locale on save, just like how Number fields work. (42310d6)