Skip to content

Conversation

@i-just
Copy link
Contributor

@i-just i-just commented Jan 23, 2026

Description

When using inline editing (on the element index page), fields that were set to be not visible or editable still appeared as editable. If you made any changes to them via the inline editing mechanism, they were not saved.

Steps to reproduce:

  1. clean 5.8.23 installation
  2. create a channel type section with an entry type with a plain text field
  3. create an entry in that section, fill out the plain text field & fully save
  4. customise your element index view for that section so that the plain text field is shown in the table
  5. on the element index page, click the “Edit” button, make a change to the plain text field and press “Save” - all works as expected
  6. now set that field to only be editable when the Level equals 100 (which is a condition that’s never met in our case) and redo step 5; without this PR, you’ll see the input field for the plain text field, and if you make changes and save, the changes are not saved
  7. not remove the editable condition and set the visibility condition to Level equals 100 (which again is never met in our case), and redo step 5; you’ll get the same outcome as in step 6

With this PR in steps 6 and 7, you’ll see the field’s value, not the input, which should make it clear that they’re not editable this way.

Related issues

from a chat with @olivierbon

@i-just i-just requested a review from brandonkelly January 23, 2026 08:15
@brandonkelly brandonkelly merged commit 43a5920 into 5.x Jan 24, 2026
2 checks passed
@brandonkelly brandonkelly deleted the bugfix/inline-editing-and-conditions branch January 24, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants