Bugfix/18569 failed to impersonate with token#18571
Merged
brandonkelly merged 4 commits into4.xfrom Mar 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents an exception from being thrown when an anonymous user tries to impersonate another user via a token. An error logged in such a case will read “Unknown user tried to impersonate userId: XYZ but something went wrong.”
Leaving
return nullin such a case in v4 would still result in a redirect to the homepage or the CP login page, but in v5, an empty page would be shown, so I opted to ensure the redirection happens in both v4 and v5.A flash message won’t be shown unless you log into the control panel with your credentials straight after failed impersonation.
Related issues
#18569