Bugfix/18648 matrix actions and read only mode#18652
Merged
brandonkelly merged 7 commits into5.xfrom Mar 31, 2026
Merged
Conversation
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In general, matrix entries (in any view mode) were not copyable when the owner was not editable.
In
5.8.18, we made matrix entries copyable when in static mode (one entry type allowed, and min/max set to the same value) (#17901).In
5.9.0, we made matrix entries in blocks mode copyable as a result of this discussion: #18013 (link to the commit in the discussion).As of 5.9.0:
issues:
root causes:
re 2 => the copy action doesn’t work because when querying for the copied element to show its chip in the notification, the query doesn’t find and return the entry, and that’s because in the case the entry is already soft-deleted
re 2 and 3 => pasting doesn’t work because we’re not clearing
revisionIdThis PR ensures that it’s possible to copy the matrix entries from a revision and paste them into an editable context.
It also ensures that the duplicate and delete actions are not available when the field is static.
Related issues
#18648