Fixes vite assets in dev mode#18831
Merged
Merged
Conversation
riasvdv
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #18801 vite assets are broken when using the dev server because the vite server can't serve from the
/legacy/path.craftAssetwill create a dev URL such as https://craft6-dev.ddev.site:5173/legacy/pluginstore/dist/images/craft.svg but the server doesn't know where to find/legacy/assets. It expects everything to be in the configuredpublicDirdirectory. We can't just have the/resources/directory be the public directory or vite will treat the js/ and css/files as static files.In the end, this little middleware makes things work for the moment. We may want to revisit the whole structure here down the road