Skip to content

[6.x] Fix blank element source headings#18891

Merged
brandonkelly merged 2 commits into
6.xfrom
rias/cms-2095-6x-blank-headings-on-entries-sidebar
May 15, 2026
Merged

[6.x] Fix blank element source headings#18891
brandonkelly merged 2 commits into
6.xfrom
rias/cms-2095-6x-blank-headings-on-entries-sidebar

Conversation

@riasvdv
Copy link
Copy Markdown
Contributor

@riasvdv riasvdv commented May 15, 2026

  • Preserve blank element source heading values when source settings are saved.
  • Normalize existing heading source configs that are missing the heading key so the element sources backend returns valid data.
  • Add regression coverage for saving and returning blank headings.

Root cause

In 6.x, Laravel request handling converts empty string form values to null. Blank source headings were therefore saved without a heading key, and the unchanged _elements/sources.twig template later failed when rendering that malformed backend data.

Related issues

Fixes #18889

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 15, 2026

CMS-2095

@riasvdv riasvdv force-pushed the rias/cms-2095-6x-blank-headings-on-entries-sidebar branch from d324c94 to c26de38 Compare May 15, 2026 10:38
@riasvdv riasvdv marked this pull request as ready for review May 15, 2026 10:44
@riasvdv riasvdv requested a review from brandonkelly May 15, 2026 10:44
@riasvdv riasvdv changed the title Fix blank element source headings [6.x] Fix blank element source headings May 15, 2026
@brandonkelly brandonkelly merged commit df63cbb into 6.x May 15, 2026
18 checks passed
@brandonkelly brandonkelly deleted the rias/cms-2095-6x-blank-headings-on-entries-sidebar branch May 15, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants