You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the craft\commerce\adjusters\Shipping::_createAdjustment() requires a ShippingRule as one of its arguments. This forces third-party plugins or modules to extend ShippingRule rather than simply implementing ShippingRuleInterface.
At a cursory glance, it appears that the only thing preventing the use of the ShippingRuleInterface is that _createAdjustment() calls toArray() on the ShippingRule. This could be addressed by adding a getSnapshot() method to the ShippingRuleInterface.
Is this something that could be addressed for Commerce v6 since this would be a breaking change?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Currently, the
craft\commerce\adjusters\Shipping::_createAdjustment()requires aShippingRuleas one of its arguments. This forces third-party plugins or modules to extendShippingRulerather than simply implementingShippingRuleInterface.At a cursory glance, it appears that the only thing preventing the use of the
ShippingRuleInterfaceis that_createAdjustment()callstoArray()on theShippingRule. This could be addressed by adding agetSnapshot()method to theShippingRuleInterface.Is this something that could be addressed for Commerce v6 since this would be a breaking change?
All reactions