allow path to be passed as the pagination URL#1710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It’s possible to set the
feedUrlto a path, but it’s not possible to do the same with thepaginationUrl. This PR adds the ability to use a path as thepaginationUrl.We need to keep the mechanism that ensures the absolute pagination URL out of the box, so this PR adds
allowPathInPaginationUrlsettings, which isfalseby default and keeps the current behaviour. When set totrue, if the value passed to thepaginationUrlis deemed relative, it won’t be turned into an absolute URL. The setting can be configured via theconfig/feed-me.phpfile, and, like other settings, can be set globally or on a per-feed basis.Related commits:
38f3607
555c0ee
Related issues
#1610, #1708