Skip to content
This repository was archived by the owner on Jul 11, 2022. It is now read-only.
This repository was archived by the owner on Jul 11, 2022. It is now read-only.

Not clear which DB backups are being created on destroy #146

@brandonkelly

Description

@brandonkelly

When the destroy command is backing up the databases, it’s not clear which database is currently getting backed up:

For example you end up staring at something like this for a while:

Created backup "all-dbs-200520_113700.sql", downloading...

and it’s not clear which database that was until the filename is finally written out once it’s done:

Backup completed and stored in "/Users/brandon/.nitro/backups/nitro-dev/mysql_5.7_3306/all-dbs-200520_113700.sql"

I think that initial status line should be replaced with:

Backing up all databases from MySQL 5.7 (port 3306) ... done
Downloading backup ... done
Backup saved to /Users/brandon/.nitro/backups/nitro-dev/mysql_5.7_3306/all-dbs-200520_113700.sql

(Even if it’s quick, i think it’s worth outputting that first line (sans-done message) while the backup is being initially created within the VM.)

Metadata

Metadata

Labels

enhancementNot really required but improves quality of life

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions