Skip to content
This repository was archived by the owner on Jul 11, 2022. It is now read-only.
This repository was archived by the owner on Jul 11, 2022. It is now read-only.

nitro stop shouldn't throw error if no containers are running #336

@lindseydiloreto

Description

@lindseydiloreto

Description

When running nitro stop from the command line, it's job is to stop all running Nitro containers (whatever they may be).

However, if no containers were running to begin with, it's actually throwing an error...

❯ nitro stop
Error: there are no running containers

If no containers were running in the first place, it should just finish successfully. Because it did what it set out to do... close all running Nitro containers (and there were none).

Steps to reproduce

  1. Have no containers running.
  2. Run nitro stop from the command line.

Additional info

  • Nitro version: 2.0.7
  • Docker version: 20.10.5

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions