Skip to content

Upgrade to GraphQl 26#837

Merged
sumerjabri merged 1 commit into
craftercms:developfrom
jmendeza:feature/graphql-upgrade
Apr 30, 2026
Merged

Upgrade to GraphQl 26#837
sumerjabri merged 1 commit into
craftercms:developfrom
jmendeza:feature/graphql-upgrade

Conversation

@jmendeza
Copy link
Copy Markdown
Member

@jmendeza jmendeza commented Apr 29, 2026

Upgrade to GraphQl 26

Summary by CodeRabbit

  • Refactor
    • Improved internal GraphQL schema construction to enforce proper type constraints for additional types, enhancing type safety and consistency in schema building.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Walkthrough

The changes update type annotations in GraphQL schema handling, replacing GraphQLType with GraphQLNamedType across two related classes to ensure consistency with GraphQL schema API type expectations.

Changes

Cohort / File(s) Summary
GraphQL Schema Factory
src/main/java/org/craftercms/engine/graphql/impl/GraphQLFactoryImpl.java
Updated additionalTypes collection type from Set<GraphQLType> to Set<GraphQLNamedType> in the buildSchema method for type alignment.
Schema Customizer
src/main/java/org/craftercms/engine/graphql/impl/SchemaCustomizer.java
Updated field, method parameter, and return type from GraphQLType to GraphQLNamedType for additional types handling; consolidated imports with wildcard statement.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is minimal and lacks the recommended structure from the template. Only a brief title is provided without details about changes, rationale, or testing. Expand the description to include what specifically was upgraded in GraphQL 26, why these changes were necessary, how they were tested, and clarify the interdependency with the craftercms PR #8642.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Upgrade to GraphQl 26' accurately describes the main objective of the PR, which updates the codebase to use GraphQL 26 by adjusting type parameters and imports.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jmendeza
Copy link
Copy Markdown
Member Author

Please notice this PR is interdependent with craftercms/craftercms#8642

@sumerjabri sumerjabri merged commit 12efd79 into craftercms:develop Apr 30, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants