Remove CommonLifecycleApi. Remove default controller scripts in blueprints#3797
Merged
sumerjabri merged 1 commit intocraftercms:developfrom Aug 12, 2025
Merged
Remove CommonLifecycleApi. Remove default controller scripts in blueprints#3797sumerjabri merged 1 commit intocraftercms:developfrom
sumerjabri merged 1 commit intocraftercms:developfrom
Conversation
WalkthroughThis PR removes the Groovy-based CommonLifecycleApi and deletes multiple Groovy controller scripts across several blueprints that instantiated and invoked it for content lifecycle operations. Changes
Sequence Diagram(s)sequenceDiagram
participant Studio
participant Controller (Groovy)
participant CommonLifecycleApi
Note over Studio: Before (old flow)
Studio->>Controller (Groovy): contentLifecycleOperation + params
Controller (Groovy)->>CommonLifecycleApi: new(params).execute()
CommonLifecycleApi-->>Controller (Groovy): onX handler
Controller (Groovy)-->>Studio: completion
Note over Studio: After (new flow in this PR)
Studio-->>Studio: No Groovy controller/CommonLifecycleApi path
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (25)
💤 Files with no reviewable changes (25)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
sumerjabri
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove CommonLifecycleApi. Remove default controller scripts in blueprints
craftercms/craftercms#8086
Summary by CodeRabbit