Skip to content

Conversation

@craigthomas
Copy link
Owner

This PR cleans up the source files and re-organizes them into better modules. It also does the following:

  • README.md updated to point to correct uber-jar file for examples.
  • Apache commons-cli removed and replaced with JCommander.
  • Test files cleaned up.
  • Explicit scopes inserted instead of relying on default package protection.
  • Codacy issues addressed.

@codecov-io
Copy link

codecov-io commented Feb 7, 2018

Codecov Report

Merging #7 into master will increase coverage by 3.06%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #7      +/-   ##
============================================
+ Coverage     77.48%   80.55%   +3.06%     
  Complexity      199      199              
============================================
  Files            12       13       +1     
  Lines           875      833      -42     
  Branches         59       54       -5     
============================================
- Hits            678      671       -7     
+ Misses          191      155      -36     
- Partials          6        7       +1
Impacted Files Coverage Δ Complexity Δ
src/com/chip8java/emulator/runner/Arguments.java 0% <0%> (ø) 0 <0> (?)
src/com/chip8java/emulator/runner/Runner.java 0% <0%> (ø) 0 <0> (?)
src/com/chip8java/emulator/components/Screen.java 95.87% <100%> (ø) 19 <2> (?)
.../com/chip8java/emulator/components/ScreenMode.java 100% <100%> (ø) 5 <2> (?)
...java/emulator/listeners/TraceMenuItemListener.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...ava/emulator/components/CentralProcessingUnit.java 93.66% <100%> (ø) 136 <0> (?)
src/com/chip8java/emulator/components/Memory.java 100% <100%> (ø) 10 <1> (?)
...mulator/listeners/ResetMenuItemActionListener.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...8java/emulator/listeners/StepMenuItemListener.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...rc/com/chip8java/emulator/components/Keyboard.java 42.1% <33.33%> (ø) 6 <2> (?)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d075883...5727552. Read the comment docs.

Update to address codacy issues.

Add missing return statement.
@craigthomas craigthomas merged commit cd55a4c into master Feb 7, 2018
@craigthomas craigthomas deleted the codacy-updates branch February 23, 2018 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants