Conversation
|
I totally forgot about your original PR already. 😄 I'm going to close #172 in favor of this one because it's much more powerful. I'd prefer calling them "form options" rather than just "options" to clarify what they are, i.e. please rename |
Form/Step.php
Outdated
There was a problem hiding this comment.
Either the type hint or the is_array check can be removed. Having both is useless. I'm tending slightly into removing the type hint to be consistent with the type handling of the other setters.
1 similar comment
Form/Step.php
Outdated
There was a problem hiding this comment.
$formOptions please. The string for the step config should be 'form_options' like you did, but not the property.
|
I'm seeing one issue with this now: What should happen if one option is defined in all three possible places, e.g. |
|
@fullpipe: But you just need to fix those two remaining commit comments. I'll rebase, squash, merge then. |
|
Thank you, @fullpipe. |
Sorry for looooooong response.
Rebased. Test added.