- 
                Notifications
    
You must be signed in to change notification settings  - Fork 12
 
Added method to count URLs in a frontier #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1b56246    to
    dc346d8      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have a separate PR for making the iterator closeable as it is not just for counting the URLs.
Autoclosable means that the close method is invoked automatically on objects managed by the try-with-resources statement. I don't think we use any try-with.
Why use AutoCloseable instead of Closeable?
        
          
                service/src/main/java/crawlercommons/urlfrontier/service/rocksdb/RocksDBService.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                service/src/main/java/crawlercommons/urlfrontier/service/CloseableIterator.java
          
            Show resolved
            Hide resolved
        
              
          
                service/src/main/java/crawlercommons/urlfrontier/service/memory/URLQueue.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                service/src/main/java/crawlercommons/urlfrontier/service/rocksdb/RocksDBService.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
          
 Separate PR for CloseableIterator in: #115 I will rebase this one after merge of #115  | 
    
Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
…nsitivity Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
Requested changes have been implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments, thanks
        
          
                client/src/main/java/crawlercommons/urlfrontier/client/Client.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                service/src/main/java/crawlercommons/urlfrontier/service/AbstractFrontierService.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                service/src/main/java/crawlercommons/urlfrontier/service/AbstractFrontierService.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      Set client version to 2.5-SNAPSHOT Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
Added a method to count the number of URLs in a frontier with an optional search filter.
Modified ListURLs to add also the optional search filter
Case sensitivity is enabled by default on search filter with an option to disable it