Skip to content

Conversation

@klockla
Copy link
Collaborator

@klockla klockla commented Nov 19, 2024

Added a method to count the number of URLs in a frontier with an optional search filter.
Modified ListURLs to add also the optional search filter
Case sensitivity is enabled by default on search filter with an option to disable it

@klockla klockla added enhancement New feature or request API Server rocksDB issues related specifically to the RocksDB based service labels Nov 19, 2024
@klockla klockla requested review from jnioche and removed request for jnioche November 19, 2024 15:30
@klockla klockla marked this pull request as draft November 20, 2024 14:42
@klockla klockla force-pushed the counturl branch 2 times, most recently from 1b56246 to dc346d8 Compare November 21, 2024 13:56
Copy link
Collaborator

@jnioche jnioche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a separate PR for making the iterator closeable as it is not just for counting the URLs.
Autoclosable means that the close method is invoked automatically on objects managed by the try-with-resources statement. I don't think we use any try-with.
Why use AutoCloseable instead of Closeable?

@klockla
Copy link
Collaborator Author

klockla commented Nov 25, 2024

Let's have a separate PR for making the iterator closeable as it is not just for counting the URLs. Autoclosable means that the close method is invoked automatically on objects managed by the try-with-resources statement. I don't think we use any try-with. Why use AutoCloseable instead of Closeable?

Separate PR for CloseableIterator in: #115

I will rebase this one after merge of #115

Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
…nsitivity

Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
@klockla klockla self-assigned this Nov 27, 2024
@klockla klockla marked this pull request as ready for review November 27, 2024 10:14
@klockla klockla requested a review from jnioche November 27, 2024 10:14
Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
@klockla klockla dismissed jnioche’s stale review December 3, 2024 09:45

Requested changes have been implemented

@jnioche jnioche added this to the 2.5 milestone Jan 8, 2025
Copy link
Collaborator

@jnioche jnioche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments, thanks

Set client version to 2.5-SNAPSHOT

Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
@klockla klockla requested a review from jnioche January 16, 2025 17:00
@klockla klockla merged commit 08ad668 into crawler-commons:master Jan 17, 2025
2 checks passed
@klockla klockla deleted the counturl branch January 17, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API enhancement New feature or request rocksDB issues related specifically to the RocksDB based service Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants