Update metadata.json #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@crayfishx could you give this a short review and release the fix? |
bastelfreak
force-pushed
the
Raskil-metadata-json-fix
branch
from
697cae0 to
fa78622
Compare
According to the specs (https://puppet.com/docs/puppet/7.4/modules_metadata.html) name should use dash as separator not slash. This triggers an error when doing a metadata-json-lont on this module. It als prevents our IDE (RubyMine) from correctly resolving module dependencies.
bastelfreak
force-pushed
the
Raskil-metadata-json-fix
branch
from
fa78622 to
8f163a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specs (https://puppet.com/docs/puppet/7.4/modules_metadata.html) name should use dash as separator not slash. This triggers an error when doing a metadata-json-lont on this module. It als prevents our IDE (RubyMine) from correctly resolving module dependencies. Also allow latest dependencies.