refactor(smell-014): decompose query() into focused helper methods#145
Merged
Conversation
…teQuery, executeQueryFp64 helpers - Extract resolveQueryParams() for parameter resolution and validation - Extract executeQuery() for FP32 FFI call - Extract executeQueryFp64() for FP64 FFI call - query() body reduced from ~124 lines to ~15 lines - Refactored queryFp64(), queryWithReranker(), queryWithRerankerFp64() to reuse helpers - Eliminated duplicated FFI parameter setup and output field handling - Added tests/test_query_decomposition.phpt (14 test cases) - All 132 tests pass, no regressions
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.