PHP 8.2 — Remove conditional memory_reset_peak_usage() call

[s2x]

PHP 8.2 — Remove conditional memory_reset_peak_usage() call

Problem Description

In the file src/Http/HttpRequestHandler.php there is a conditional call to the memory_reset_peak_usage() function, which checks the PHP version before calling it:

if (PHP_VERSION_ID >= 80200) {
    \memory_reset_peak_usage();
}

Since the project is dropping support for PHP 8.1 and now requires PHP 8.2+, this condition is unnecessary and can be removed.

Location

• /home/decodo/work/workerman-bundle/src/Http/HttpRequestHandler.php lines 49-51

Analysis

Current code (lines 47-51):

public function __invoke(TcpConnection $connection, Request $request): void
{
    if (PHP_VERSION_ID >= 80200) {
        \memory_reset_peak_usage();
    }
    // ...
}

The memory_reset_peak_usage() function was introduced in PHP 8.2 and is used to reset peak memory usage. The condition PHP_VERSION_ID >= 80200 was necessary when the project supported PHP 8.1, but is now redundant.

Proposed Solution

Remove the if condition and call the function directly:

public function __invoke(TcpConnection $connection, Request $request): void
{
    \memory_reset_peak_usage();
    // ...
}

Change:

• Remove lines 49-51 (the if block)
• Leave only the call \memory_reset_peak_usage(); on line 49

Priority

🔵 MINOR — code cleanup. This change does not affect functionality, but simplifies the code and removes an unnecessary condition that will always be satisfied in the new PHP 8.2+ environment.

Tests

After making changes:

1. Run vendor/bin/phpunit to ensure the HTTP handler works correctly
2. Check if there are any memory-related errors in the logs
3. Verify operation during HTTP request handling

[s2x]

✅ Acceptance Requirement

Before this issue can be closed, a corresponding entry must be added to CHANGELOG.md following the Keep a Changelog format.

The changelog entry should be added under the `## [Unreleased]] section and include:

• A brief description of the change
• Reference to this issue number (e.g., (#47))
• Appropriate section: Added, Changed, Fixed, Removed, or Deprecated

[s2x]

✅ Acceptance Requirement

Before this issue can be closed, a corresponding entry must be added to CHANGELOG.md following the Keep a Changelog format.

The changelog entry should be added under the `## [Unreleased]] section and include:

• A brief description of the change
• Reference to this issue number (e.g., (#47))
• Appropriate section: Added, Changed, Fixed, Removed, or Deprecated

[s2x]

Issue #47 has been implemented - the conditional PHP_VERSION_ID >= 80200 check has been removed and memory_reset_peak_usage() is now called directly in HttpRequestHandler.php (line 51).

✅ Change verified: unconditional call to memory_reset_peak_usage() is in place
✅ PHPUnit tests pass

Ready to close.