Skip to content

Add GitHub Actions workflow for automatic releases#80

Merged
s2x merged 2 commits intomasterfrom
feature/github-actions-release
Apr 3, 2026
Merged

Add GitHub Actions workflow for automatic releases#80
s2x merged 2 commits intomasterfrom
feature/github-actions-release

Conversation

@s2x
Copy link
Copy Markdown
Collaborator

@s2x s2x commented Apr 3, 2026

Summary

This PR adds a GitHub Actions workflow that automatically creates GitHub releases when version tags are pushed.

Changes

  • Added .github/workflows/release.yaml
  • Workflow triggers on tags starting with v (e.g., v1.0.0)
  • Uses softprops/action-gh-release@v2 for creating releases
  • Automatically generates release notes based on merged PRs and commits

How to use

After merging, simply push a new tag to create a release:

git tag v0.12.0
git push origin v0.12.0

The workflow will automatically create a GitHub release with generated release notes.

Closes #77

@s2x
Copy link
Copy Markdown
Collaborator Author

s2x commented Apr 3, 2026

Code Review Summary

Strengths

  • Uses pinned versions for actions
  • Minimal permissions (only contents: write)
  • Simple and focused workflow

Issues Found

Important:

  • Permissions should be at the top level, not job level

Minor:

  • Consider using SHA pins instead of version tags for better security

Recommendation

The workflow is well-structured. Consider moving the permissions block to the top level of the workflow file for better clarity.

Verdict: Approved with minor suggestions.

@s2x s2x merged commit 9b2d98e into master Apr 3, 2026
21 checks passed
@s2x s2x deleted the feature/github-actions-release branch April 3, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GitHub Actions workflow for automatic releases

1 participant