Make checkbox stateless #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using props to set the initial state of the checkbox results in the duplication of the "true state" of the checkbox in both this code and the caller that handles the
onClickcallback. Make this component stateless so that the caller is the main "keeper of the state".Example where the current code would fail:
Have a screen with a "Reset Checkbox" button. Clicking this button would do nothing since the props change is not handled. One solution would be to add
componentWillReceivePropsbut I'd imagine the caller would almost always maintain the checkbox state itself through theonClickcallback.