test(mockMiddleware): use fake timers#209
Merged
paibamboo merged 2 commits intocrazyfactory:masterfrom Oct 12, 2020
Merged
Conversation
Collaborator
Author
|
@paibamboo can you add a label: "hacktoberfest-accepted" on this PR :) |
paibamboo
approved these changes
Oct 12, 2020
Contributor
|
🎉 This PR is included in version 1.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now that we're using fake timers it might run tiny bit faster (shouldn't be noticable), but there's a kinda trick in this thing, I'll create a issue to follow up with jestjs/jest#2157 and we can do it non dirty way.
closes #161