Skip to content

[codex] clarify issue and pr defaults and language rules#1

Merged
crazygit merged 3 commits intomainfrom
codex/issue-pr-defaults-and-language
Apr 17, 2026
Merged

[codex] clarify issue and pr defaults and language rules#1
crazygit merged 3 commits intomainfrom
codex/issue-pr-defaults-and-language

Conversation

@crazygit
Copy link
Copy Markdown
Owner

Summary

  • align issue-create and issue-pr with the intended defaults for labels and self-assignment
  • require Chinese titles and descriptions for generated Issues and PRs while keeping commit messages in English
  • add skill-loading assertions so these constraints are covered by tests

Why

The current skill docs were inconsistent about default label/assignee behavior and PR language requirements. This change makes the expected defaults explicit and prevents regressions.

Validation

  • bash tests/skill-loading/run-tests.sh
  • bash tests/state-machine/run-tests.sh

@github-actions
Copy link
Copy Markdown

🤖 Hi @crazygit, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## 📋 Review Summary

This PR successfully clarifies the language requirements and default behaviors for Issues, Pull Requests, and Commits. It establishes a clear convention of using Chinese for user-facing content (Issues/PRs) while maintaining English for developer-facing commit messages, and adds automated tests to enforce these constraints.

🔍 General Feedback

  • Consistency: The alignment between issue-create and issue-pr labels is a great improvement.
  • Automation: Adding skill-loading tests for documentation content is a proactive way to prevent regressions in AI instructions.
  • Clarity: The explicit mention of --assignee "@me" and Chinese language rules removes ambiguity for the AI agent.

Comment thread tests/skill-loading/run-tests.sh
Comment thread skills/issue-pr/SKILL.md Outdated
Comment thread skills/issue-pr/SKILL.md Outdated
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation and command logic for the issue-commit, issue-create, and issue-pr skills to standardize language and metadata. Key changes include enforcing Chinese for Issue and PR titles and bodies while explicitly keeping commit messages in English. Additionally, the PR introduces automatic assignment to the current user via --assignee "@me" and implements default label inheritance and mapping for both Issues and PRs. New tests have been added to verify these content constraints across the modified skills. I have no feedback to provide as no review comments were submitted.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@crazygit
Copy link
Copy Markdown
Owner Author

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation and workflow instructions for issue creation, pull requests, and commits. Key changes include enforcing Chinese for issue and PR titles and bodies while keeping commit messages in English, and adding requirements for default labels and automatic assignment to the current user. Review feedback points out a syntax error in the newly added test script and formatting artifacts (stray '+' signs) in the documentation that need to be corrected.

Comment thread tests/skill-loading/run-tests.sh Outdated
Comment thread skills/issue-pr/SKILL.md Outdated
Comment thread skills/issue-pr/SKILL.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@crazygit crazygit marked this pull request as ready for review April 17, 2026 10:47
@crazygit crazygit merged commit beacf2e into main Apr 17, 2026
@crazygit crazygit deleted the codex/issue-pr-defaults-and-language branch April 17, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant