modernize build: jdk 17, github actions, license, tests#1
Merged
Conversation
DatatypeConverter is gone since jdk 11. use java.util.Base64 and bump the compiler release to 11 so this builds on current jdks.
Owner
Author
|
Reviewed the diff: no behavior changes to the runtime path beyond the Base64 swap (same output, just the supported API). Actions build is green and the 8 new tests pass. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dusting off this one so it builds and runs on a current JDK.
javax.xml.bind.DatatypeConverter(removed in JDK 11) withjava.util.Base64inPageletBodyTagPageletTaskOutputHolderand the executor's task validation (8 tests)main(), renameisPageletTasksince it returned the oppositemvn clean verifypasses locally on JDK 17.