Skip to content

Conversation

@mobot95
Copy link
Contributor

@mobot95 mobot95 commented Aug 7, 2024

What does this PR do?

Add option to manually specify config file path

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@crazywhalecc crazywhalecc added new feature New feature or request kind/framework Issues related to CLI app framework need test This PR has not been tested yet, cannot merge now labels Aug 7, 2024
@crazywhalecc
Copy link
Owner

Sorry for late reply, I noticed this argument is not included for MacOSBuilder, and Windows PHP build process seems don't use --with-config-file-path. It would be even better if these could be improved.

@crazywhalecc crazywhalecc removed the need test This PR has not been tested yet, cannot merge now label Aug 20, 2024
@crazywhalecc crazywhalecc merged commit ec584bf into crazywhalecc:main Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/framework Issues related to CLI app framework new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants