Conversation
* Make the `SIMDJSON_ERR_*` constants case-sensitive in all PHP versions. (The code it was based on was missing the flag needed to mark constants as case sensitive before PHP 8) * Fix a bug that prevented using JSON pointer in `simdjson_key_count`, `simdjson_key_exists`, and `simdjson_key_value` with a leading slash https://www.rfc-editor.org/rfc/rfc6901.html. Fix a bug that was introduced when working around test failures following a change in json pointer validation in the underlying C simdjson library. * "" in a JSON pointer $key continues to refer to the entire document. * "/" in a JSON pointer $key now properly refer to the key that is the empty string. * Continue to allow the non-standard omission of the leading "/" for compatibility with earlier PECL releases. This may be deprecated in a subsequent release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the
SIMDJSON_ERR_*constants case-sensitive in all PHP versions.(The code it was based on was missing the flag needed to mark constants
as case sensitive before PHP 8)
Fix a bug that prevented using JSON pointer in
simdjson_key_count,simdjson_key_exists, andsimdjson_key_valuewith a leading slashhttps://www.rfc-editor.org/rfc/rfc6901.html. (The workaround would convert
/footo//foo, which would look up$value['']['foo'])Fix a bug that was introduced when working around test failures
following a change in json pointer validation in the underlying C simdjson library.
"" in a JSON pointer $key continues to refer to the entire document.
"/" in a JSON pointer $key now properly refers to the key that is the empty string.
Continue to allow the non-standard omission of the leading "/" for
compatibility with earlier PECL releases.
This may be deprecated in a subsequent release.