Added SetSize functionality#39
Merged
Merged
Conversation
…it size from master's pty to slave. Changes type winsize to make it accessible from outside the package.
dlundquist
reviewed
Dec 6, 2016
dlundquist
left a comment
dlundquist
left a comment
There was a problem hiding this comment.
I've been looking to building a remote terminal application using this, but the asymmetry between server and client (in an SSH/telnet context) functions is a blocker. Adding SetSize() would be provide parity with GetSize(). Have you considered just introducing SetSize() and simply accepting a rows and columns arguments rather than exposing winsize?
|
Just curious if you intend to merge this? |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added terminal/pty resize functionality and utility function to inherit size from master's pty to slave. Changes type winsize to make it accessible from outside the package.