Skip to content

Reduce bundle size#105

Merged
akmadian merged 4 commits intomasterfrom
reduce-size
Mar 2, 2020
Merged

Reduce bundle size#105
akmadian merged 4 commits intomasterfrom
reduce-size

Conversation

@obulat
Copy link
Contributor

@obulat obulat commented Feb 27, 2020

Description

This PR aims to reduce the bundle size by 'tree-shaking': deep importing of components and css.

Other information

Checklist:

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
@akmadian
Copy link
Member

akmadian commented Mar 2, 2020

I'm unsure if Olga's work on this is done, but I'm merging anyways cause we've made great progress, and I'd like to have everything clean when outside contributors come in.

If there's more optimization to be done, we can re-visit in the future.

@akmadian akmadian merged commit faf4c5f into master Mar 2, 2020
@akmadian akmadian deleted the reduce-size branch March 2, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants