Fixing link hover colour problem.#127
Merged
akmadian merged 5 commits intocreativecommons:masterfrom Mar 7, 2020
Merged
Conversation
akmadian
requested changes
Mar 5, 2020
Member
akmadian
left a comment
There was a problem hiding this comment.
This change works for the license statement, but only the license statement so far. This change does not apply to the link to the github repo, the email address, or the phone number in the footer.
I would just go with keeping the same blue color, and adding an underline like you have now, but apply it to all a tags, and scope it to the footer component.
Contributor
Author
|
Hello @akmadian , done! |
akmadian
approved these changes
Mar 7, 2020
Member
akmadian
left a comment
There was a problem hiding this comment.
Looks great! Thanks for working on this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108
Description
I have modified the CSS rules. Previously, hovering the links in the footer changed the colour to make it illegible to read. Now, it has been fixed. A hovered link is now underlined.
Other information
Checklist
Update index.md).masterbranch of the repository.visible errors.
Developer Certificate of Origin