Conversation
Signed-off-by: Olga Bulat <obulat@gmail.com>
akmadian
approved these changes
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olga Bulat obulat@gmail.com
Fixes
Fixes #126 by @akmadian
Description
Unit and e2e tests for Stepper component.
Technical details
Unit tests have 100% coverage of the Stepper component.
The e2e tests use page objects to make tests more readable.
This PR adds two changes to the code: removes obsolete handling of the step-header click for steps that the user hasn't interacted with yet, and adds stepName to step-header classes to make testing easier.
Checklist
Update index.md).masterbranch of the repository.visible errors.
Developer Certificate of Origin
Developer Certificate of Origin