Fixed the tests of LicenseCode.vue and LicenseDetailsCard.vue#154
Merged
obulat merged 3 commits intocreativecommons:masterfrom Apr 3, 2020
Merged
Fixed the tests of LicenseCode.vue and LicenseDetailsCard.vue#154obulat merged 3 commits intocreativecommons:masterfrom
obulat merged 3 commits intocreativecommons:masterfrom
Conversation
obulat
approved these changes
Apr 3, 2020
Contributor
obulat
left a comment
There was a problem hiding this comment.
Thank you for submitting this PR so quickly!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #153 by @obulat and removes to return the tracked object
Description
The e2e tests of
LicenseCode.vueandLicenseDetailsCard.vuestarted to break because of some click handler error thisPRfixes them. Also since the $ga was removed from the tests ofHelpsection.vueI removed the modifications that I did to theclickHandlerfunction to return the object which I used to test it. At this point when I ran npm run test all the unit and e2e tests were passingScreenshots
Screenshot after the completion of tests
Unit tests screenshot with Helpsection highlighted
Checklist
Update index.md).masterbranch of the repository.visible errors.
Developer Certificate of Origin
Developer Certificate of Origin