Responsive layout fixes, HelpSection.vue content changes, HeaderSection.vue and FooterSection.vue navigation changes

[possumbilities]

Fixes

Fixes:

• [Bug] Remove hardcoded CloudFront CDN (use default Cloudflare CDN) #418
• [Bug] logo is misaligned on various viewports along the horizontal axis #439
• [Bug] The nav hamburger appears, despite there being no menu present on certain viewports #440
• [Content] Update HelpSection.vue questions #441
• [Feature] Remove Feedback links in HeaderSection.vue and FooterSection.vue #442

Description

• [Bug] Remove hardcoded CloudFront CDN (use default Cloudflare CDN) #418

  index 6e9f3a0..ab5b1db 100644
  --- public/index.html
  +++ public/index.html
  @@ -6,8 +6,8 @@
       <meta name="viewport" content="width=device-width,initial-scale=1.0">
       <meta name="description" content="Want to license your work with Creative Commons, but not sure where to start, or which license is right for you? Use our license chooser!">
       <link rel="icon" href="<%= BASE_URL %>favicon.ico">
  -    <link rel="icon" type="image/png" href="https://d15omoko64skxi.cloudfront.net/wp-content/uploads/2016/05/cc-site-icon-300x300.png" sizes="192x192">
  -    <link rel="apple-touch-icon-precomposed" href="https://d15omoko64skxi.cloudfront.net/wp-content/uploads/2016/05/cc-site-icon-300x300.png">
  +    <link rel="icon" type="image/png" href="https://creativecommons.org/wp-content/uploads/2016/05/cc-site-icon-300x300.png" sizes="192x192">
  +    <link rel="apple-touch-icon-precomposed" href="https://creativecommons.org/wp-content/uploads/2016/05/cc-site-icon-300x300.png">
       <meta name="twitter:card" content="summary" />
       <meta name="twitter:site" content="@creativecommons" />
       <meta name="twitter:creator" content="@creativecommons" />

• [Bug] logo is misaligned on various viewports along the horizontal axis #439

  • Before
    
    

  • After
    

• [Bug] The nav hamburger appears, despite there being no menu present on certain viewports #440

  • Before
    

  • After
    

• [Content] Update HelpSection.vue questions #441

  • Before
    

  • After
    

  • The previous questions can be viewed by checking out Release 0.2.0:

    git fetch --all --tags

    git checkout tags/0.2.0 -b branch-0.2.0

• [Feature] Remove Feedback links in HeaderSection.vue and FooterSection.vue #442

  • Before
    
    

  • After
    
    

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main or master).
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no
  visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[possumbilities]

All of the unit tests pass:

But at current the cypress end-to-end tests all fail. Looking through the logs that's been going on for a while and started at #371 I'm unsure of the specific cause.

It does look like the #371 (comment) denotes that the change to correct the iframe error on the cypress tests requires the commands in the test pipeline be updated accordingly, but I don't know that they were.

9 PRs have been merged since theses tests began failing (and without them passing successfully).

It all warrants further investigation to sort the actual cause, since they all fail at the moment.

[TimidRobot]

looks great!

[Cronus1007]

@possumbilities I have found the fix for cypress end to end tests. So I will be opening a new issue to resolve that bug. Plus we would also require to discuss the upgradation of cypress from 6.x version to 12.x version the latest version.