[Fix] icon overlay issue of the close button in modal

[egbadon-victor]

Fixes

• Fixes [Bug] The closing button for the "Confused need help " pop up pages is aligning with the cc logo #546 by @akshathere

Description

This PR fixes the issue with the cc logo icon appearing of the close icon on the modals. This is largely a temporary fix.

Technical details

The issue was caused by how vocabulary handles the .icon* classes, which replaces icons that are not in vocabulary with the cc icon as a default.
From careful inspection of the code, the modal was handled by an app-modal component, which was imported from the @creativecommons/vocabulary-components npm package.
Because this package is based on the vue implementation of the legacy vocabulary code, it meant that I couldn't access or edit the source component directly. Hence, I implemented a new modal component, AppModal which is the new wrapper for the ChooserModal component contents. This new component now has a corrected implementation of the close icon.

Additional Notes

I must add that this implementation is temporary, as there is no close icon in the the vocabulary design system yet. A more permanent solution would be to;

1. Update the vocabulary repo to include a close icon
2. Update the version of Vocabulary in this repo to the version with the close icon implemented
3. Implement the close icon as prescribed by the vocabulary guidelines.

Tests

• Run the source code on your local machine.
• Scroll down the the "Confused? Need Help?" section
• Click on any of the questions and observe the modal.
• Run the docker compose exec chooser-node npm run test command and observe your terminal and confirm no errors were logged.

Screenshots

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main or master).
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no
  visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[netlify]

✅ Deploy Preview for creativecommons-chooser ready!

Name	Link
🔨 Latest commit	d93d9be
🔍 Latest deploy log	https://app.netlify.com/sites/creativecommons-chooser/deploys/672a8d181deec60008e03aa6
😎 Deploy Preview	https://deploy-preview-548--creativecommons-chooser.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[possumbilities]

Wonderful! Approved.