add baseline templates for the various licenses, to load dynamically in "rec area" when a matching license is found from state.current#562
Merged
possumbilities merged 14 commits intorefactorfrom Jan 15, 2025
Conversation
…lone instead of append templates (for better reuse)
templates for the various license, to load dynamically in "rec area" when a matching license is found from state.currenttemplates for the various licenses, to load dynamically in "rec area" when a matching license is found from state.current
TimidRobot
approved these changes
Jan 15, 2025
Member
TimidRobot
left a comment
There was a problem hiding this comment.
Looks good--exciting to see it come together!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
<template>for eachlicenselicense<template>based onstate.props.licensewhen knownstate.props.cursorto track current step, and clear any selections left from a previous journey through the steps afterward.licensebased on valid pathways of selection through the stepperTechnical details
state, tracking that and aligning both thestatewith the various UI elements found within the steppers, to keep them in sync along chosen pathwaystemplateto be generalized more, and sub-divided into sub-templates; and an argument for full conversion to Web Components, but at this stage I don't see the benefit yet at that level of abstraction, and I'm not sure that's necessary in the final refactor either.Next up, is rendering out the "mark you work" section, pulling relevant input data from the "attribution details" text inputs. I'll also utilize
<template>here, and keep the output rendering to a minimum (likely only doing plain text formatting for now. Later formatting can be built out in later PRs.Screenshots
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin