Skip to content

add html comments on header and footer#10

Merged
hugosolar merged 3 commits intomasterfrom
header-footer-comments
May 11, 2020
Merged

add html comments on header and footer#10
hugosolar merged 3 commits intomasterfrom
header-footer-comments

Conversation

@hugosolar
Copy link
Copy Markdown
Contributor

Fixes

Fixes #7 by @TimidRobot

Description

Add HTML comments on header and footer

<!--BEGIN HEADER-->
<!--END HEADER-->
<!--BEGIN FOOTER-->
<!-- END FOOTER-->

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@hugosolar hugosolar requested a review from TimidRobot May 10, 2020 14:01
@hugosolar hugosolar self-assigned this May 10, 2020
@hugosolar hugosolar requested a review from aldenstpage May 11, 2020 14:03
Comment thread footer.php Outdated
Copy link
Copy Markdown
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hugosolar hugosolar merged commit d1c14a9 into master May 11, 2020
@hugosolar hugosolar deleted the header-footer-comments branch May 11, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add HTML Comments around the WordPress HTML we want to use other places

3 participants