Skip to content

Revert cc global in favour of legacy files#178

Merged
brylie merged 2 commits into
creativecommons:mainfrom
MuluhGodson:revert_cc_global
Feb 4, 2022
Merged

Revert cc global in favour of legacy files#178
brylie merged 2 commits into
creativecommons:mainfrom
MuluhGodson:revert_cc_global

Conversation

@MuluhGodson
Copy link
Copy Markdown
Member

Fixes

Fixes https://github.com/creativecommons/project_creativecommons.org/issues/208 by @MuluhGodson

Description

This PR removes the CC-Global-Components and replaces them with the legacy files.

Technical details

The CC Global package is developed with vue 3 and this is a conflict when the chooser package is integrated since it is developed with vue 2. For the MVP, it is sufficient to remove cc-global in favour of the legacy files. These will subsequently be updated later when chooser is upgraded to Vue 3.

Screenshots

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@MuluhGodson MuluhGodson requested a review from a team as a code owner January 31, 2022 17:11
@brylie brylie self-assigned this Feb 4, 2022
@brylie brylie merged commit bcf07a5 into creativecommons:main Feb 4, 2022
@brylie
Copy link
Copy Markdown
Contributor

brylie commented Feb 4, 2022

@all-contributors please add @MuluhGodson for code

@allcontributors
Copy link
Copy Markdown
Contributor

@brylie

I've put up a pull request to add @MuluhGodson! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants