GitHub fetch: remove double logging of errors #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub fetch: remove double logging of errors
Technical details
The end of the script manages error handling. It includes logging of
shared.QuantifyingException:quantifying/scripts/1-fetch/github_fetch.py
Lines 183 to 188 in 021e4c4
This means that the request error handling will result in two error messages per error:
quantifying/scripts/1-fetch/github_fetch.py
Lines 152 to 160 in 021e4c4
Inserting a fake error results in:
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin