resolve jamendo engine instead remove#137
Merged
possumbilities merged 2 commits intocreativecommons:mainfrom Oct 27, 2022
Merged
resolve jamendo engine instead remove#137possumbilities merged 2 commits intocreativecommons:mainfrom
possumbilities merged 2 commits intocreativecommons:mainfrom
Conversation
Contributor
Author
|
@possumbilities Hello ma'am, could you review please |
possumbilities
approved these changes
Oct 27, 2022
Contributor
possumbilities
left a comment
There was a problem hiding this comment.
Thank you! ❤️ Tested via docker, all seems sound! Approved.
Member
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #124 by @TimidRobot
Description
Redirect the user which checked "use for commercial purposes" to licensing.jamendo which contains music that can be used for commercial purposes and played in public places
Technical details
The editing was in search.js file
Tests
I replace the url that tagged for Jamendo in the right condition in the search.js file as well as i made some changes of the additional letters/symbol which they putted in the url, that be work well with that licensing.jamendo
Screenshots
Screen.Recording.1444-03-29.at.2.24.32.AM.mov
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin