dry-run should not send web hooks

[sedlund]

Do you agree?

[creativeprojects]

Hmmm yeah it probably shouldn't 🤔

[creativeprojects]

Fixed in 0.20.0

[sedlund]

Doesnt seem resolved yet on 0.20.0

resticprofile home.forget -n -vv

it's still sending a webhook

Maybe with -vv or something it should output on the cli that it is sending the webhook.

Also this one:

resticprofille home.forget -n -h

which doesnt actually run the forget command but outputs the help command also sends a webhook.

[jkellerer]

There is 2 kinds of dry-run one is for resticprofile (e.g. resticprofille --dry-run home.forget) and the other one is for restic (e.g. resticprofille home.forget --dry-run).

The difference is that if you specify dry-run for restic (when placed after the command name), resticprofile must run the normal flow of commands and run restic for this kind of dry-run to make any sense.

The fix only changed http hooks for resticprofile dry-run.

It might however make sense to catch --help (or -h) and --dry-run (-n) also for restic and not send http hooks. For the help case, we could redirect to the built-in help command to not run any command flow at all.

[jkellerer]

@creativeprojects , should we reopen this case?

[creativeprojects]

Yes I think we can spot the restic dry-run as well 👍🏻

[creativeprojects]

Fixed in v0.21.0 👍🏻