Skip to content

feat: mdoc support#313

Merged
tipusinghaw merged 3 commits intofeat/oidc-main-syncfrom
feat/mdoc-support
Oct 6, 2025
Merged

feat: mdoc support#313
tipusinghaw merged 3 commits intofeat/oidc-main-syncfrom
feat/mdoc-support

Conversation

@RinkalBhojani
Copy link
Copy Markdown
Contributor

@RinkalBhojani RinkalBhojani commented Oct 6, 2025

Support for mdoc issuance

@RinkalBhojani
added multiple namespace support for mdoc credential
c229c2b 
Signed-off-by: Rinkal Bhojani <rinkal.bhojani@ayanworks.com>
@RinkalBhojani
fixed minor issues with sd-jwt VC issuance
99c49d9 
Signed-off-by: Rinkal Bhojani <rinkal.bhojani@ayanworks.com>
@RinkalBhojani RinkalBhojani self-assigned this Oct 6, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 6, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/mdoc-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@GHkrishna GHkrishna changed the title Feat/mdoc support feat: mdoc support Oct 6, 2025
@GHkrishna GHkrishna added the feature Defines a new feature label Oct 6, 2025
@tipusinghaw
fix: resolve comments
0928c4f 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

tipusinghaw
tipusinghaw approved these changes Oct 6, 2025
View reviewed changes
src/controllers/openid4vc/issuance-sessions/issuance-sessions.service.ts Outdated
},
}

// if (cred.format === OpenId4VciCredentialFormatProfile.SdJwtVc) {
Copy link
Copy Markdown
Contributor

@tipusinghaw tipusinghaw Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this code ?

@tipusinghaw tipusinghaw merged commit 2a4b1e6 into feat/oidc-main-sync Oct 6, 2025
4 of 5 checks passed
@RinkalBhojani RinkalBhojani deleted the feat/mdoc-support branch January 2, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tipusinghaw tipusinghaw tipusinghaw approved these changes

@GHkrishna GHkrishna Awaiting requested review from GHkrishna

Assignees

@RinkalBhojani RinkalBhojani

Labels

feature Defines a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RinkalBhojani @tipusinghaw @GHkrishna