fix: custom w3c document loader

[GHkrishna]

What:

Fix incorrect custom document loader injection while creating agent

Summary by CodeRabbit

• Bug Fixes
  • Fixed the initialization of the credentials module to properly respect the custom document loader configuration setting.

[coderabbitai]

Walkthrough

The W3cCredentialsModule instantiation in src/cliAgent.ts has been inverted: when isCustomDocumentLoaderEnabled() returns true, a documentLoader is now supplied; when false, it is omitted. This reverses the previous conditional logic for module wiring.

Changes

Cohort / File(s)	Summary
W3cCredentialsModule instantiation logic src/cliAgent.ts	Inverted ternary condition for W3cCredentialsModule construction: documentLoader is now supplied when isCustomDocumentLoaderEnabled() is true and omitted when false, reversing the prior logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• credebl/credo-controller#321: Introduces isCustomDocumentLoaderEnabled() and CustomDocumentLoader, directly enabling the conditional logic now applied in this PR's module construction inversion.

Suggested reviewers

• RinkalBhojani
• sairanjit

Poem

🐰 A flip of the switch, a twist of the flow,
Where true means inclusion, and false lets it go!
The module now listens to what we command,
Custom documents loaded, just as we'd planned! 📋✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "fix: custom w3c document loader" directly addresses the main change in the changeset. The summary indicates the PR fixes incorrect custom document loader injection logic in the W3cCredentialsModule construction, specifically correcting a reversed ternary condition in src/cliAgent.ts. The title is concise, specific, and clearly conveys that this is a bug fix related to custom W3C document loader functionality, which aligns perfectly with the PR's objective to fix incorrect custom document loader injection while creating an agent.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/custom-document-loader

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dfefc8e and e9d08ab.

📒 Files selected for processing (1)

• src/cliAgent.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/cliAgent.ts (1)

src/utils/customDocumentLoader.ts (1)

• CustomDocumentLoader (28-47)

🔇 Additional comments (2)

src/cliAgent.ts (2)

188-192: Logic inversion bug fixed correctly.

The conditional now properly aligns with the semantic meaning of isCustomDocumentLoaderEnabled():

• When true → custom document loader is injected ✓
• When false → default behavior (no custom loader) ✓

This is a critical fix that reverses the previous inverted logic where enabled/disabled states were producing opposite behaviors.

---

188-192: Fix verified as logically correct, but integration tests do not exist in this repository for manual verification.

The conditional logic is correct: when isCustomDocumentLoaderEnabled() returns true, the W3cCredentialsModule is instantiated with the CustomDocumentLoader; when false, it uses the default. The implementation matches the intended behavior.

However, no integration or unit tests were found in the codebase to verify this fix at runtime. To ensure the fix works correctly in production:

1. Either add integration tests covering:

   • Custom document loader activates when ENABLE_CUSTOM_DOCUMENT_LOADER=true and required environment variables are set
   • Default behavior applies when the flag is false
   • URL replacement for deprecated W3C domains works as expected

2. Or manually verify the behavior in a test environment by:

   • Setting ENABLE_CUSTOM_DOCUMENT_LOADER=true with valid DEPRECATED_DOMAIN and CURRENT_DOMAIN values
   • Confirming requests to deprecated domains are intercepted and resolved correctly
   • Verifying default behavior when the flag is disabled

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sairanjit]

LGTM