Skip to content

fix: replace raw echo with standard output helpers in git/update-dotnet-sdk#663

Merged
credfeto merged 2 commits into
mainfrom
fix/650-echo-helpers-update-dotnet-sdk
Jun 5, 2026
Merged

fix: replace raw echo with standard output helpers in git/update-dotnet-sdk#663
credfeto merged 2 commits into
mainfrom
fix/650-echo-helpers-update-dotnet-sdk

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Jun 5, 2026

Summary

  • Replace custom die() implementation with the standard printf-based helper (coloured output to stderr)
  • Add standard info() helper using printf
  • Replace both raw echo progress messages with info calls

Changes

  • git/update-dotnet-sdk: update output helpers to match project standards

Closes #650

…et-sdk

Prompt: Replace raw echo with output helpers in git/update-dotnet-sdk (issue #650)

Closes #650
@github-actions github-actions Bot added the auto-pr Pull request created automatically label Jun 5, 2026
@dnyw4l3n13 dnyw4l3n13 changed the title chore: add changelog entry for #650 fix: replace raw echo with standard output helpers in git/update-dotnet-sdk Jun 5, 2026
@dnyw4l3n13 dnyw4l3n13 marked this pull request as draft June 5, 2026 20:33
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Urgent Urgent Priority labels Jun 5, 2026
@dnyw4l3n13
Copy link
Copy Markdown
Collaborator

Status Update

Implementation complete. Changes made in this PR:

  • Replaced custom die() (bare echo) with the standard printf-based helper (coloured stderr output)
  • Added standard info() helper using printf
  • Replaced both raw echo progress messages with info calls
  • All shell linting (shellcheck, checkbashisms) passes

CI checks are currently pending — stopping here until they complete.

@credfeto
Copy link
Copy Markdown
Owner

credfeto commented Jun 5, 2026

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13 dnyw4l3n13 marked this pull request as ready for review June 5, 2026 20:40
@dnyw4l3n13
Copy link
Copy Markdown
Collaborator

All CI checks passed. PR is ready for review.

  • All required checks: pass
  • Shell linting (BASH via Super-linter): pass
  • No outstanding review comments or questions

@credfeto
Copy link
Copy Markdown
Owner

credfeto commented Jun 5, 2026

Super-linter summary

Language Validation result
BASH Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13
Copy link
Copy Markdown
Collaborator

All checks pass and no outstanding work remains. PR is ready for review.

  • All required CI checks: pass (including BASH linting, changelog validation, secret scanning, build)
  • Copilot Code Review: pass
  • No CHANGES_REQUESTED reviews
  • No unanswered human comments

@credfeto credfeto enabled auto-merge June 5, 2026 20:47
@credfeto credfeto merged commit a008eeb into main Jun 5, 2026
46 checks passed
@credfeto credfeto deleted the fix/650-echo-helpers-update-dotnet-sdk branch June 5, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent auto-pr Pull request created automatically Urgent Urgent Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace raw echo with output helpers in git/update-dotnet-sdk

2 participants