This repository was archived by the owner on May 20, 2022. It is now read-only.
GH-155: Remove template React import#156
Merged
Conversation
In order to produce valid code, one of the tests needed to be modified so that it called the imported module—`it.todo` was preserved however.
These proved redundant since each generator validates TS compilation.
Validates that generated tests pass.
This reverts commit 70bf93d.
roblafeve
force-pushed
the
develop-GH-155-remove-template-react-import
branch
from
c61389e to
5a628ec
Compare
roblafeve
force-pushed
the
develop-GH-155-remove-template-react-import
branch
from
beb89db to
4e309dd
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Yeah, this PR does remove
import React from "react"(app-webonly), but more importantly this adds:What should I look at?
import React from "react"fromapp-mobile, but found out that wasn't going to work because of certain limitations of the expo configuration. 36badd8 reverts those changes.🔎 Reviewer Checklist