This repository was archived by the owner on May 20, 2022. It is now read-only.
Merged
Conversation
Lerna bootstrap installs all package dependencies. Now that `inflection` is imported in a TypeScript file, it has uncovered that this dependency wasn't ever present up-front but instead was present at the end. Now TS requires tht it be installed before building—of course!
This was causing consumers to run on the system version of node/npm which caused symlink references to be incorrect. We now print these versions in the consumer context to allow for better debugging in the future.
These tests run faster/slower depending on the environment. When using [act](https://github.com/nektos/act) to test actions locally, they were timing out. I'm willing to wait a minute to ensure they _really_ fail.
blaketarter
approved these changes
Jun 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds trimming of whitespace to generator input.
closes #180
📋 Acceptance Criteria
new:typenew:utilnew:componentmobilenew:componentweb👩🔬 Test Instructions
npm ci && npm run dev:setupcd consumers/app-(mobile|web)npm run new:typewith whitespacenpm run new:utilwith whitespacenpm run new:componentwith whitespace🔎 Reviewer Checklist