Skip to content
This repository was archived by the owner on May 20, 2022. It is now read-only.

64: Fix new:component web templates with tests#73

Merged
roblafeve merged 2 commits intodevelopfrom
develop-64-new-component-template-is-wrong
Oct 16, 2020
Merged

64: Fix new:component web templates with tests#73
roblafeve merged 2 commits intodevelopfrom
develop-64-new-component-template-is-wrong

Conversation

@roblafeve
Copy link
Contributor

Description

It was discovered that the web templates had the incorrect contents (it ended up being the mobile template contents). This revealed the fact that we need tests to prove correctness. Beyond that, the new:component script has branching that should be validated as well. Tests have been added for these variants.

🔗 Reference

Relevant links (e.g. issue, design, etc.)

#64

📋 Acceptance Criteria

Checked off by PR Assignees

The following snapshots accurately reflect the intended contents of each file in each scenario (and tests pass):

🔎 Reviewer Checklist

Checked off by PR Reviewers

  • Merge destination is correct
  • Code is correct as understood and conforms to quality standards
  • Tests have been added where appropriate (unit, visual, end-to-end)
  • Acceptance Criteria have been met

Roles & Responsibilities

👨‍💻 Assignee

  • Initiator of this PR (be sure to set in GitHub UI)
  • Addresses feedback and change requests
  • Merges PR once approved (usually deletes branch unless develop or release)

👩‍💻 Reviewer

  • Invited to review PR by Assignee (via GitHub UI)
  • Is expected to complete a review and address followup

@roblafeve roblafeve requested a review from blaketarter October 16, 2020 18:53
@roblafeve roblafeve self-assigned this Oct 16, 2020
@roblafeve roblafeve added bug Something isn't working enhancement New feature or request labels Oct 16, 2020
Copy link
Contributor

@blaketarter blaketarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Nice work!

@roblafeve roblafeve merged commit c5c6613 into develop Oct 16, 2020
@roblafeve roblafeve deleted the develop-64-new-component-template-is-wrong branch October 16, 2020 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants