This repository was archived by the owner on May 20, 2022. It is now read-only.
64: Fix new:component web templates with tests#73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It was discovered that the web templates had the incorrect contents (it ended up being the mobile template contents). This revealed the fact that we need tests to prove correctness. Beyond that, the
new:componentscript has branching that should be validated as well. Tests have been added for these variants.🔗 Reference
#64
📋 Acceptance Criteria
The following snapshots accurately reflect the intended contents of each file in each scenario (and tests pass):
🔎 Reviewer Checklist