-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add Arize Phoenix docs and tutorials #2413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Disclaimer: This review was made by a crew of AI Agents. Code Review Comments for the Phoenix Observability Documentation PROverviewThe PR introduces insightful documentation for integrating Arize Phoenix observability with CrewAI. The document serves as a comprehensive guide, enhancing user understanding of this integration. Positive Aspects
Suggested Improvements1. Code Block Language SpecificationObservation: Some code blocks lack language specifications. ```python
import os
from getpass import getpass3. Error Handling GuidanceObservation: There is currently no guidance on handling errors while implementing the integration. ## Troubleshooting
### Common Issues
1. **Authentication Errors**
```python
try:
tracer_provider = register(
project_name="crewai-tracing-demo",
auto_instrument=True,
)
except Exception as e:
print(f"Failed to initialize Phoenix: {e}")
5. Link Context EnhancementsObservation: Some external links could better serve the user with additional context. ## References
- [Phoenix Documentation](https://docs.arize.com/phoenix/) - Comprehensive overview of the Phoenix platform.
- [CrewAI Documentation](https://docs.crewai.com/) - Detailed usage of the CrewAI framework.
- [OpenTelemetry Docs](https://opentelemetry.io/docs/) - Official instrumentation guide.
- [OpenInference GitHub](https://github.com/openinference/openinference) - Source code for OpenInference SDK.6. Configuration OptionsObservation: Coverage of configuration options is limited. ## Advanced Configuration
### Custom Trace Sampling
```python
from opentelemetry.sdk.trace.sampling import TraceIdRatioBased
tracer_provider = register(
project_name="crewai-tracing-demo",
auto_instrument=True,
sampler=TraceIdRatioBased(0.5) # Sample 50% of traces
)Custom Tagsfrom opentelemetry import trace
tracer = trace.get_tracer(__name__)
with tracer.start_as_current_span("custom_operation") as span:
span.set_attribute("custom.tag", "value") |
|
I've responded to the feedback around references and version control up above! I think the configuration options are not quite valid. Let me know if you'd like to make further edits! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! cc: @tonykipkemboi if you have time, can you take a look at this
|
One tiny ask, @exiao, please add the file name ( |
|
@tonykipkemboi , I added it and made it alphabetical to match the rest of your docs! LMK if this is not what you meant! |
this is good. meant to do that anyways, thank you. |
tonykipkemboi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G2G!

For customers and prospects who use Arize Phoenix for observability and crewAI for building their agents, we wrote some instructions on how to do so! If you could merge them, that would be amazing!
https://docs.arize.com/phoenix/tracing/integrations-tracing/crewai