Skip to content

fixes mem0 with valkey/redis issue#4055

Closed
MatthiasHowellYopp wants to merge 2 commits intocrewAIInc:mainfrom
MatthiasHowellYopp:mh/fix/valkey
Closed

fixes mem0 with valkey/redis issue#4055
MatthiasHowellYopp wants to merge 2 commits intocrewAIInc:mainfrom
MatthiasHowellYopp:mh/fix/valkey

Conversation

@MatthiasHowellYopp
Copy link

@MatthiasHowellYopp MatthiasHowellYopp commented Dec 9, 2025

changes to support using mem0 with valkey/redis as external memory provider for crewai

fixes #4031


Note

Medium Risk
Changes request shaping for Mem0 search filters with provider-specific behavior, which could alter query results for Valkey/Redis users; test coverage is expanded to reduce regressions.

Overview
Fixes Mem0Storage search filters for local Mem0 vector stores that don’t support nested AND/OR filter structures (Valkey/Redis) by flattening single-condition AND filters to a plain dict, while leaving multi-condition/OR filters and cloud MemoryClient behavior unchanged.

Adds targeted tests covering Valkey/Redis flattening, non-flattening cases, None config edge cases, and the cloud-vs-local guard; also updates pytest setup to reset the last event id between tests for better isolation.

Written by Cursor Bugbot for commit 7a255c9. This will update automatically on new commits. Configure here.

@Vidit-Ostwal
Copy link
Contributor

Vidit-Ostwal commented Feb 3, 2026

Hey @MatthiasHowellYopp, maybe you can collapse all the commits into one for a cleaner git history

Try this

git checkout feature-branch
git reset --soft main
git commit -m "Add <feature-name>"
git push --force-with-lease

I am not a maintainer, feel free to ignore this...

@greysonlalonde
Copy link
Contributor

Hey @MatthiasHowellYopp, maybe you can collapse all the commits into one for a cleaner git history

Try this

git checkout feature-branch
git reset --soft main
git commit -m "Add <feature-name>"
git push --force-with-lease

I am not a maintainer, feel free to ignore this...

This would be great!

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@MatthiasHowellYopp
Copy link
Author

@greysonlalonde changes done, looks like I need you (or someone) to let the checks run.

@MatthiasHowellYopp
Copy link
Author

@greysonlalonde can you review - or recommend someone who can? tks.

@MatthiasHowellYopp
Copy link
Author

@greysonlalonde Can we try again? looks lIke I need workflow approval and a review.

@MatthiasHowellYopp MatthiasHowellYopp force-pushed the mh/fix/valkey branch 4 times, most recently from e095719 to 8bc007d Compare February 6, 2026 19:14
@MatthiasHowellYopp
Copy link
Author

@greysonlalonde Is there something I can do to get this to the other side of merged? Seems I'm back to needing the checks permitted.

@MatthiasHowellYopp
Copy link
Author

@greysonlalonde Can you approve the awating workflows, please?

@MatthiasHowellYopp
Copy link
Author

fixes #4030

@MatthiasHowellYopp MatthiasHowellYopp force-pushed the mh/fix/valkey branch 4 times, most recently from 1568393 to 61a8f22 Compare February 12, 2026 18:57
@MatthiasHowellYopp
Copy link
Author

MatthiasHowellYopp commented Feb 17, 2026

no longer relevant

@Vidit-Ostwal
Copy link
Contributor

no longer relevant

@MatthiasHowellYopp
Copy link
Author

working on a version that works with the new memory architecture.

@Vidit-Ostwal
Copy link
Contributor

working on a version that works with the new memory architecture.

@MatthiasHowellYopp MatthiasHowellYopp deleted the mh/fix/valkey branch March 3, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants