Make sys.stdout/stderr filtering opt-in#4585
Open
thakoreh wants to merge 2 commits intocrewAIInc:mainfrom
Open
Make sys.stdout/stderr filtering opt-in#4585thakoreh wants to merge 2 commits intocrewAIInc:mainfrom
thakoreh wants to merge 2 commits intocrewAIInc:mainfrom
Conversation
The FilteredStream was unconditionally wrapping sys.stdout and sys.stderr at module import time, affecting all code that imports crewai.llm. This is a global side effect that library code should not impose on users. Changes: - Filtering is now opt-in via CREWAI_FILTER_LITELLM_OUTPUT env var - Added enable_litellm_filtering() helper function for programmatic use - Users who want the old behavior can set CREWAI_FILTER_LITELLM_OUTPUT=1 Fixes: crewAIInc#3000
Contributor
|
This PR is stale because it has been open for 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3000 - Stop hijacking sys.stdout and sys.stderr
Problem
The FilteredStream was unconditionally wrapping sys.stdout and sys.stderr at module import time, affecting all code that imports crewai.llm. This is a global side effect that library code should not impose on users.
As noted in Python docs for contextlib.redirect_stdout:
Solution
Make the filtering opt-in:
Changes