fix: ensure memory drain in akickoff async method#4768
Open
jnMetaCode wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: ensure memory drain in akickoff async method#4768jnMetaCode wants to merge 1 commit intocrewAIInc:mainfrom
jnMetaCode wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
The sync kickoff() method calls self._memory.drain_writes() in its finally block to ensure background memory saves complete before returning. The async akickoff() method is missing this call, which can lead to lost memory writes when using async execution. Signed-off-by: JiangNan <1394485448@qq.com>
Contributor
|
This PR is stale because it has been open for 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sync
kickoff()method includes adrain_writes()call in itsfinallyblock to ensure all background memory saves complete before returning:The async
akickoff()method is missing this call, which means memory writes may be lost when using async execution. This was likely a copy-paste oversight whenakickoffwas added.Fix
Added the same
drain_writes()guard toakickoff()'s finally block.Note
Medium Risk
Low-complexity change, but it adds a blocking
drain_writes()call to an async code path, which could impact latency or surface exceptions during shutdown.Overview
Crew.akickoff()now mirrorskickoff()by draining pending background memory writes in itsfinallyblock (guarded byhasattr(self._memory, "drain_writes")) before clearing files and detaching context.This prevents async executions from returning before queued memory saves complete, reducing the chance of dropped memories.
Written by Cursor Bugbot for commit 46f0736. This will update automatically on new commits. Configure here.