fix: make NL2SQLTool dialect-aware for SQLite and PostgreSQL#5332
Open
Krithi-murugesan wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: make NL2SQLTool dialect-aware for SQLite and PostgreSQL#5332Krithi-murugesan wants to merge 1 commit intocrewAIInc:mainfrom
Krithi-murugesan wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
Author
|
Hi maintainers 👋 Adding some context for this PR: What I tested Validated NL2SQLTool with both SQLite and PostgreSQL Why this matters Fixes runtime failures for SQLite users Happy to add more tests or refine further if needed. Thanks! |
Author
|
Please apply the llm-generated label as this contribution was assisted by an LLM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixed dialect compatibility issues in the NL2SQLTool to support SQLite and PostgreSQL.
Why
The original tool used hardcoded PostgreSQL queries on system tables like information_schema.tables.
This caused runtime errors on SQLite, which doesn’t have those tables.
How
Replaced hardcoded SQL with SQLAlchemy's dialect-agnostic inspect module to dynamically discover tables and columns.
This approach works across supported databases without errors.